Send initialized notification in DNS rebinding scenario#340
Open
jstar0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send
notifications/initializedafter the DNS rebinding scenario completes a successful dated-specinitializeprobe against the valid localhost Host/Origin pair.Root Cause / Context
The scenario currently performs a valid
initializerequest for the localhost Host/Origin check, then marks the check successful without completing the dated MCP initialization lifecycle. Servers that requirenotifications/initializedafter a successfulinitializecan fail or hang even though the Host/Origin validation itself is correct.Changes
Mcp-Session-Idreturned by the valid Host/Origin initialize probe.notifications/initializedfor dated specs after the valid initialize succeeds, preserving the session id when one is issued.server/discoverpath unchanged.server/discoverno-notification boundary.Scope / Risk
This only changes the DNS rebinding scenario's valid-host success path. The invalid Host/Origin rejection probe is unchanged, and
server/discovertraffic still does not sendnotifications/initialized.Verification
All commands passed.
Closes #338